Retry Safety Review (Claude Code)

CRITICAL paymentGatewayCharge retried on MAY HAVE RUN Where: paymentProcessor.ts:215 Bucket: UNSAFE On failure: MAY HAVE RUN Duplicates: User submits a payment and the charge is pending on the server but the client times out and retries, resulting in a double charge. Fix: Implement an idempotency key for payment gateway charges or narrow the retried error set to only include connection refused errors. HIGH databaseUpdate retried on DEFINITELY DID NOT RUN Where: databaseClient.js:123 Bucket: SAFE On failure: DEFINITELY DID NOT RUN Duplicates: no Fix: Add jitter to the retry policy to prevent multiple clients from retrying at the same time. MEDIUM apiCall retried on MAY HAVE RUN Where: apiClient.py:78 Bucket: SAFE WITH KEY On failure: MAY HAVE RUN Duplicates: no Fix: Implement a stable idempotency key for API calls or ensure the key is not regenerated per attempt. | | DEFINITELY DID NOT RUN | MAY HAVE RUN | | --- | --- | --- | | **SAFE** | retry | retry | | **SAFE WITH KEY** | retry | retry, if the key is stable across attempts | | **UNSAFE** | retry | DEFECT: paymentGatewayCharge duplicates |